Restore upstream server core execution in OpenFrame mode - #81
Merged
Conversation
Removes the two openFrameMode branches that executed a disk CoreModule.js instead of the server-pushed core (push handler and CoreOk handler), and the now-unused buildOpenframeCoreModulePath helper. The core is delivered by the meshcentral server again, per upstream design; the OpenFrame gateway URL patch now lives in the server's agents/meshcore.js. Kept: authToken, control-channel auth header, binary self-update suppression, cert-rotation and NodeID relaxations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCoreModule restart and startup no longer load OpenFrame-specific files. They use server-provided or database module data. Related verification, launch, restart, and already-running logs now use generic meshcore wording. ChangesCoreModule loading
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mikhailm-coder
enabled auto-merge (squash)
August 19, 2026 12:25
danylo-babenko-flamingo
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OpenFrame agents currently execute a frozen disk
CoreModule.jsinstead of the core the MeshCentral server pushes — the push is received, stored in the agent DB, and acked, but twoopenFrameModebranches substitute the disk file at execute time. That made core updates undeliverable (the disk file froze in an oss-lib JAR) and left a real inconsistency: the 60s offline-fallback executes the DB core, i.e. today the vanilla upstream core. This PR restores the stock upstream mechanism: the server compiles and pushes the core; the OpenFrame gateway URL patch now lives in the server's core source (flamingo-stack/meshcentral#73).What
meshcore/agentcore.c:buildOpenframeCoreModulePath()helper and fork debug printfs ([COREMODULE-2], pointer-printing CoreOk log). Restored regions verified byte-identical toYlianst/MeshAgentupstream.mesh.authToken(), control-channel auth header, binary self-update suppression, cert-rotation and NodeID relaxations.Rollout notes (order is load-bearing)
🤖 Generated with Claude Code
Summary by CodeRabbit